Add support for AIM SSC. - #1793
Conversation
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1793 +/- ##
==========================================
+ Coverage 81.98% 82.06% +0.07%
==========================================
Files 216 216
Lines 26796 26806 +10
Branches 4242 4245 +3
==========================================
+ Hits 21970 21999 +29
+ Misses 3355 3340 -15
+ Partials 1471 1467 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| # precedence over the value of collect_ai. | ||
| # Apply collect_ai first so that when agent_config settings from SSC | ||
| # are applied, they will override collect_ai if needed. | ||
| collect_ai = server_side_config.get("collect_ai", None) |
There was a problem hiding this comment.
Shouldn't this be agent_config instead of server_side_config?
There was a problem hiding this comment.
Do we need to do a pop here instead of a get to ensure it doesn't loop over this same setting and override the value out of order in the code below?
There was a problem hiding this comment.
collect_ai actually isn't sent up in the agent_config block. It is its own key within the connect response payload.
I can add a pop for collect_ai. The call to apply_config_setting(settings_snapshot, name, value) in the server_side_config loop shouldn't actually affect any logic with ai_monitoring.enabled since it's looking for the name collect_ai. However, it isn't necessary to store the value of collect_ai in the settings_snapshot if we've already done the override on line 1663 so I can get rid of it.
|
Tick the box to add this pull request to the merge queue (same as
|

Support server side configuration of AIM settings in NR1
Precedence:
If ai_monitoring.enabled is present in the connect response, this value MUST take precedence to override the ai_monitoring.enabled value and fallback on using the value from collect_ai. For example, if collect_ai is False, and ai_monitoring.enabled locally is True, the agent would ultimately disable AI Monitoring. If both collect_ai is False and ai_monitoring.enabled is True in the connect response, ai_monitoring.enabled would ultimately enable AI Monitoring. If HSM is enabled, the appropriate AI monitoring settings SHOULD be set appropriately in the connect response. As a safeguard however, agents SHOULD also enforce HSM mode on AI settings they receive from the connect response.