Skip to content

Melpa package of magithub broken #11

Description

Hello,

I have magit and magithub installed with M-x package-list-packages. When I try to load magit (yes, magit, not magithub), I get this error:

(void-variable magit-log-edit-confirm-cancellation)

This is what's happening:

  • loading magit triggers loading magithub because of

;;;###autoload
(eval-after-load 'magit
'(unless (featurep 'magithub)
(require 'magithub)))

  • in magithub, there is this form:

(defcustom magithub-message-confirm-cancellation magit-log-edit-confirm-cancellation
"If non-nil, confirm when cancelling the editing of a `magithub-message-mode' buffer."
:group 'magithub
:type 'boolean)

  • evaluating it raises the error because magit-log-edit-confirm-cancellation is not defined.

Maybe the variable has been removed? Dunno.

Michael.

Activity

  1. pashinin commented on Aug 18, 2013

    @pashinin

    Confirm

  2. pokehanai commented on Aug 19, 2013

    @pokehanai

    +1

  3. added a commit that references this issue on Aug 19, 2013
    5c74fa2
  4. aspiers commented on Aug 20, 2013

    @aspiers

    +1

  5. ocodo commented on Sep 3, 2013

    @ocodo

    Question, why is this closed when the MELPA install is still broken?

  6. flexibeast commented on Sep 3, 2013

    @flexibeast

    @jasonm23:

    As far as I can tell, looking at the issue status indicator at the top of this page, this issue isn't closed. If I'm understanding things correctly, the 'Closed' indicator earlier in this thread is a reference to the issue being closed on the /magit/ repo, as the issue is not with magit itself, but with /magithub/, a distinct project.

  7. ocodo commented on Sep 3, 2013

    @ocodo

    @flexibeast thanks for clearing that up. It seems that the melpa package is still a release from July. (?)

  8. flexibeast commented on Sep 3, 2013

    @flexibeast

    @jasonm23:

    Yes, that's the latest release I'm seeing also .... Basically I've uninstalled magithub until this issue is fixed, so that I can at least continue using magit.

  9. Blaisorblade commented on Sep 6, 2013

    @Blaisorblade

    I had the same problem.
    It seems that saving magithub-message-confirm-cancellation from M-x customize-group RET magithub RET also works the problem around (I guess because once the variable is set, reading the default isn't needed any more).

  10. dcunited001 commented on Sep 10, 2013

    @dcunited001

    +1

  11. alexvorobiev commented on Sep 29, 2013

    @alexvorobiev

    Adding (defvar magit-log-edit-confirm-cancellation nil) prior to loading magit is another workaround.

  12. Blaisorblade commented on May 4, 2014

    @Blaisorblade

    Apparently magithub is unsupported and does not work anyway, see melpa/melpa#1126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions