Repository navigation
Conversation
|
Important Review skippedToo many files! This PR contains 552 files, which is 252 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
⛔ Files ignored due to path filters: 2
📒 Files selected for processing: 552
You can disable this status message by setting the
Comment |
Owner
Author
|
@coderabbitai full review |
|
Owner
Author
|
Source PR sleepypod#824 superseded by merged stack sleepypod#828–sleepypod#831 - closing proxy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned source head:
7b9ac5d37add24275ba18bae0403f144819f8bc1. Dedicated base matches source dev at0922bc08e407956ecba45e18daeaaeb67d5b8806to preserve other proxy PRs.Biometric personalization previously lacked a shared, reproducible path from reference comparison to an acknowledged runtime change. This adds per-side versioned profiles, retained evaluations and explicit activation/rollback across the web UI, REST/tRPC and MCP. Original observations retain their provenance and stay distinct from current-classifier views and replay results.
The implementation includes:
Validation at
7b9ac5d3: 6,887 Vitest tests passed (18 skipped), across 482 passing test files. Browser tests, all seven Python module jobs, both builds, TypeScript and lint passed. Patch coverage is 87.73%, passing the repository's unchanged eight-point margin below its 88.93% target. Pre-push checks also passed. The added regressions cover coordinator admission/cancellation/resource ownership, discovery boundaries, retained report publication/release, and the live-shadow exit race.Target-pod resource evidence includes an eight-hour, three-configuration synthetic replay completed in 45.94 minutes with zero read/API failures and unchanged fixture canonical observations. The separate 30-minute synthetic shadow supervisor measurement completed in 61.34 seconds with confirmed cleanup and zero probe failures. A subsequent 180-second live source/isolated sink run completed with six retained comparison points, zero canonical rows in the isolated database and 1,587 successful read-only API probes. It exposed and verified a fix for RSS disappearance during clean worker exit. Detailed identities, observations and limitations are in docs/biometrics-replay-benchmark.md.
Synthetic performance evidence does not establish clinical accuracy. Validated promotion and prospective shadow admission still require matching reviewed qualification registries; no success is fabricated when that evidence is absent. See docs/biometrics-calibration-readiness.md for the acceptance map and remaining rollout evidence.
Deployed build
4c3a6a6e(including the live-shadow exit fix) is verified on the target pod: calibration/health endpoints return 200, replay admission is configured and admitted, core and numerical services are active, and the data-path verdict is healthy. No user profile or hardware temperature setting was changed. Subsequent changes add tests, a measurement harness and documentation; they do not change the deployed runtime.CodeRabbit full review was requested in this PR. The provider skipped it because the change exceeds its 100-file review limit; its passing check does not mean a review was completed. All build, test and coverage checks pass on the final revision; see the checks panel for current status.