Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
- Coverage 89.00% 88.99% -0.01%
==========================================
Files 111 111
Lines 12457 12489 +32
==========================================
+ Hits 11087 11115 +28
- Misses 1368 1372 +4
Partials 2 2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
6 tasks
|
Hmm, I don't know if I like the fact that this is only possible by writing to a file. With lots of traffic, that file will get huge, fast. Is this something we just aren't going to be able to do right now? It feels like we need a change to core nginx in order to add metadata to metrics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds Kubernetes Gateway API route and gateway identity attributes (
nginx.route.*andnginx.gateway.*) to thenginx.http.requestsmetric. Aggregates per-route request counts from access logs.To populate route and gateway metadata, NGINX Gateway Fabric access logs must be written to a regular file on a shared volume rather than the default
/dev/stdoutdestination.Stub status scraper continues to emit global totals. If access log file destination is not configured, existing stub status metrics are uninterrupted.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)