Repository navigation
chore: expose resource as prop, but value handled in state - #321
Draft
michael-small wants to merge 3 commits into
Draft
michael-small wants to merge 3 commits into
michael-small wants to merge 3 commits into
Conversation
michael-small
commented
Oct 25, 2026
| @@ -1,2 +1,2 @@ | |||
|
|
|||
| pnpm --no -- commitlint --edit ${1} | |||
Collaborator
Author
There was a problem hiding this comment.
Ignore. I was having pnpm issues and this suddenly was giving me issues, I will likely revert this.
michael-small
commented
Oct 25, 2026
| @@ -0,0 +1,28 @@ | |||
| { | |||
Collaborator
Author
There was a problem hiding this comment.
Ignore. This is just convenient when working on this. Will later remove.
michael-small
commented
Oct 25, 2026
|
|
||
| constructor() { | ||
| effect(() => { | ||
| // Four things |
Collaborator
Author
There was a problem hiding this comment.
This is the heart of this draft right now, the proposed points. The actual implementation and tests are a bit rough and sparse, but I was able to have the intended experience while drafting this code up in its current state in the demo.
…oolkit#301) Approved by Rainer over DMs
michael-small
changed the base branch from
feat-withResource-take-Resource-type
to
main
November 14, 2026 16:45
michael-small
force-pushed
the
feat-generate-resource-as-prop
branch
from
November 14, 2026 17:19
ddea05a to
eca80cb
Compare
michael-small
changed the base branch from
main
to
feat-withResource-take-Resource-type
November 14, 2026 17:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context, see the notes in the demo component
with-resource-component, rather than duplicate said description.@rainerhahnekamp this is the definite proposal to make, but based on the top of the outstanding open PR for adding more resource types than
ResourceRef. This draft hasn't been fully tested/vetted in practice at this point, but the types and points to be made line up as you can see in practice in the demo component notes as I see the long term vision.