scripts, docs: Use root instead of NIAuth admin for target access#354
Open
shubhanshumt26 wants to merge 1 commit into
Open
scripts, docs: Use root instead of NIAuth admin for target access#354shubhanshumt26 wants to merge 1 commit into
shubhanshumt26 wants to merge 1 commit into
Conversation
The system login is moving off the NIAuth-backed "admin" user to the local "root" user, since ni-auth no longer ships the NSS/PAM modules that resolved the admin identity. Update the helper scripts and docs that log in to or reference the target accordingly: - provisioning expect tests: USER admin -> root. - upstream_merge test util: scp/ssh path :/home/admin -> :/home/root. - README.kernel.md: ssh/scp admin@$TARGET -> root@$TARGET.
shubhanshumt26
force-pushed
the
local-root-login
branch
from
5f20bc1 to
0f1f40c
Compare
shubhanshumt26
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates developer-facing scripts and documentation to use the local root user (instead of the NIAuth-backed admin user) when logging into or copying artifacts to a target, aligning with the move away from NIAuth NSS/PAM modules.
Changes:
- Updated provisioning Expect tests to log in as
root. - Updated upstream merge test utility to copy the safemode image to
/home/root. - Updated kernel README commands to use
root@$TARGETforssh/scp.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/tests/provisioning/test_safemode_provision.expect | Switches VM login user from admin to root for safemode provisioning tests. |
| scripts/tests/provisioning/test_rauc_provision.expect | Switches VM login user from admin to root for RAUC provisioning tests. |
| scripts/tests/provisioning/migrate_vm_to_safemode.expect | Switches VM login user from admin to root during migration-to-safemode flow. |
| scripts/dev/upstream_merge/utils/test.py | Updates safemode image SCP destination from /home/admin to /home/root. |
| docs/README.kernel.md | Updates documented target access commands from admin@$TARGET to root@$TARGET. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
21
| set USER root | ||
|
|
||
| set RE_PROMPT "(admin|root)@.*# $" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
AB#3650235
Changes
The system login is moving off the NIAuth-backed "admin" user to the local "root" user, since ni-auth no longer ships the NSS/PAM modules that resolved the admin identity.
Update the scripts and docs that log in to or reference the target accordingly:
admin -> root.scp/ssh path :/home/admin -> :/home/root.admin@$TARGET -> root@$TARGET.Testing
Performed testing under this meta-nilrt PR that has all the functional changes.