Skip to content

Issue #44 : feat(cli): validate checks @widget routes and widgets/out HTML - #58

Open
Shreyavemana wants to merge 32 commits into
nitrocloudofficial:developfrom
Shreyavemana:feat/validate-widgets
Open

Shreyavemana wants to merge 32 commits into
nitrocloudofficial:developfrom
Shreyavemana:feat/validate-widgets

Conversation

@Shreyavemana

Copy link
Copy Markdown
Collaborator

Summary

nitrostack-py validate did not check widget routes or their HTML files, so missing or empty widgets/out/<route>.html went undetected after init.

Findings

  • validate_project in cli/validators.py only ran dependency, import, and module checks — no widget validation.
  • ensure_python_widgets in cli/main.py created widget HTML during init and generate, but nothing re‑checked files afterwards.

Proposal

  • Add validate_widgets to validate_project.
  • Collect @widget routes using the same patterns as ensure_python_widgets.
  • Print route → file → URI in warning messages.
  • Warn when a widget file is missing, empty, or has an invalid route.

Tests

  • 9 new tests in tests/test_validate_widgets.py cover missing, empty, valid, duplicate, invalid, vendored, and no‑widget cases.
  • Targeted run: 78 passed. Full suite: ~840 passed (Windows shows unrelated OAuth flake).

manish-wekan and others added 30 commits September 10, 2026 18:05
…ase PR.

Keep pyproject.toml and uv.lock in sync, skip a bump while a version is still unpublished, and only hit the PyPI environment when an upload will actually run.
Bring the bump/publish workflows in line with develop (via main) so the PR can merge.
…ure/release-automation

Automate version bumps and PyPI publishes from main
.env values were written over os.environ unconditionally, so the PORT=3000
that `nitrostack init` puts in .env overrode the PORT a host passes when
starting the server. NitroStudio starts a second project on 3001; it bound
3000 anyway and died with "address already in use" (NITSTD-222).

Keys already in the process environment are now kept, as with
python-dotenv and Node's dotenv. .env still fills keys the process
doesn't set, and defaults stay lowest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…process-env-wins-over-dotenv

ConfigService: process environment wins over .env
publish.yml only uploads through PyPI trusted publishing, which has never
run here, and the Bump version workflow can't open its release PR (the org
doesn't allow GitHub Actions to create pull requests). The script covers
both: optionally makes release/<next> from origin/main (--bump), checks the
branch matches origin, the lockfile matches and the version is new, runs the
tests, builds, twine-checks, uploads after asking, verifies a clean install
from PyPI, and opens the release PR. `--tag` tags origin/main after the merge.
`--dry-run` stops before anything leaves the machine.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Run from a temp copy: --bump switches branches, which can rewrite the
  script while bash is still reading it.
- --bump plans from origin/main's files in a scratch folder and checks
  everything before switching, so a failed check no longer leaves you on a
  detached origin/main.
- Only a 404 counts as "not on PyPI"; offline or PyPI errors stop the run
  instead of passing the "version is new" check.
- No terminal and no --yes means "no" instead of a silent exit.
- Tag the uploaded commit right after the upload (no separate step that
  could tag later, unreleased merges on main). --tag stays for catching up
  untagged releases and prefers the release branch head.
- A failed PR creation after the upload prints the manual step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README is the PyPI project page. Rewrite it for 0.4.x: building
blocks (tools, resources, prompts, guards, auth, caching, rate limits,
tasks, events, health), env precedence, templates, clients.

tests/test_readme_examples.py compiles every python block, checks every
nitrostack import exists, and runs the Quick Start and Building Blocks
examples through the testing harness so the page can't drift.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e/release-script

Add scripts/release.sh for releasing to PyPI by hand
…/readme-refresh

docs: refresh README (PyPI page) for the current SDK
`nitrostack-py upgrade` failed on every project `init` creates: the
dependency pattern also matched `nitrostack = { path = "vendor/nitrostack" }`
in [tool.uv.sources] and produced an invalid pyproject.toml. Spec rewrites
are now limited to [project].dependencies, and the pattern skips paths
ending in /nitrostack.

Fixing that alone isn't enough: a vendored project runs vendor/nitrostack
whatever spec it declares, and uv accepts a spec the vendored copy doesn't
satisfy. For vendored projects, upgrade now replaces vendor/nitrostack
with the target release (copied from the running CLI when it is that
release, otherwise the PyPI wheel, checked against its sha256). The new
tree is built beside the old one and swapped in, so a failed download
leaves the project as it was.

init's next steps said NitroStudio can't open Python projects; it can.
The pizzaz open-shops hint is printed only for the pizzaz template.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…upgrade-vendored

Fix upgrade on vendored projects; correct init's NitroStudio note
`init` vendors the SDK into vendor/nitrostack. `validate` walked it as
project code, and nitrostack/testing applies @mcp_app to a class defined
inside a function, so every vendored project that imported
nitrostack.testing failed with "uses @mcp_app but no decorated
application class was found after import". Compose's typecheck runs
`validate`, so a NitroStudio build could not get past it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…validate-skip-vendored-sdk

validate: skip the vendored SDK
Align Python pack with the TypeScript CLI: optional inclusion of .env
files in the wheel, with a warning that lists paths without printing values.
…/pack-include-env

pack: add --include-env
…/producthunt-badge

docs: add Product Hunt featured badge to README
…/producthunt-top-post-badge

docs: update Product Hunt badge to nitrocloudofficial#1 Product of the Day top-post badge
@Shreyavemana
Shreyavemana marked this pull request as ready for review October 19, 2026 12:09
@Shreyavemana Shreyavemana changed the title feat(cli): validate checks @widget routes and widgets/out HTML Issue #44 : feat(cli): validate checks @widget routes and widgets/out HTML Oct 19, 2026
@Shreyavemana

Shreyavemana commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

Verification of the proposed fix (feat/validate-widgets, 9df0e74)

Changes: Added widget validation to detect missing or empty widget HTML files and flag invalid routes. Added 9 tests covering valid, invalid, missing, empty, duplicate, vendored, and no-widget cases.

Installation and test environment

Cloned the branch into a temporary directory, created a fresh virtual environment, and installed the package using pip install <repo>.

The checks were run against the installed package from outside the repository. The installed version was nitrostack 0.4.2, imported from the temporary virtual environment's site-packages\nitrostack directory, confirming that the CLI validation checks were tested against the installed package rather than the source checkout.

Results:

  • 78 targeted tests passed, covering test_validate_widgets.py and test_cli.py.
  • 840 tests passed in the full test suite.
  • 3 manual checks passed: Missing and empty widget files triggered warnings, while a valid file passed validation.
  • 0 errors reported. The only remaining warning was about the missing application class in the sample project.

Conclusion: The fix works as expected: the CLI detects missing or empty widget HTML files, and all targeted and full-suite tests passed on Windows.

@Shreyavemana
Shreyavemana force-pushed the feat/validate-widgets branch from 9df0e74 to fe7f0fd Compare October 21, 2026 15:06
@Shreyavemana
Shreyavemana changed the base branch from main to develop October 23, 2026 14:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants