Skip to content

CI: add benchmark report - #173

Merged
JuhoErvasti merged 4 commits into
mainfrom
ci-benchmark-report
Oct 19, 2026
Merged

JuhoErvasti merged 4 commits into
mainfrom
ci-benchmark-report

Conversation

@JuhoErvasti

@JuhoErvasti JuhoErvasti commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

I think this'll be a useful addition to the ongoing optimization work; this adds a workflow which runs when a PR is opened from branch perf* to main and adds a benchmark report as a comment to the PR.

Should allow us to better keep track of changes. It also lays the groundwork for eventually adding testing for performance regressions, personally I'd like to test this out first and introduce hard limits on regressions when more of the optimizations have already been done.

The report only includes cases with a relative change of at least 25% (either faster or slower). This is an arbitrary number and may have to be adjusted, but we can't go with too low of a number due performance variance in the CI runners.

I've tested this in a personal fork, see here (or no changes).

Type of change

  • Bug fix

  • New feature

  • Other

  • Non-breaking change

  • Breaking change

Developer checklist

  • A CHANGELOG entry has been included (only when change is visible to users)

@JuhoErvasti

Copy link
Copy Markdown
Collaborator Author

@nlssjritakallio
Ready for review, I changed this a bit so that all the results are reported, but the less meaningful results are hidden in a </details> block, I figure it doesn't hurt to have them available, but hidden by default:

kuva

@sritakallio sritakallio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tool!

@JuhoErvasti
JuhoErvasti merged commit e9eff2f into main Oct 19, 2026
3 checks passed
@JuhoErvasti
JuhoErvasti deleted the ci-benchmark-report branch October 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants