Repository navigation
CI: add benchmark report - #173
Merged
Merged
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
I think this'll be a useful addition to the ongoing optimization work; this adds a workflow which runs when a PR is opened from branch
perf*tomainand adds a benchmark report as a comment to the PR.Should allow us to better keep track of changes. It also lays the groundwork for eventually adding testing for performance regressions, personally I'd like to test this out first and introduce hard limits on regressions when more of the optimizations have already been done.
The report only includes cases with a relative change of at least 25% (either faster or slower). This is an arbitrary number and may have to be adjusted, but we can't go with too low of a number due performance variance in the CI runners.
I've tested this in a personal fork, see here (or no changes).
Type of change
Bug fix
New feature
Other
Non-breaking change
Breaking change
Developer checklist