Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeoTools was pulled in twice: by
hakunapi-proj-gtfor reprojection and byhakunapi-gpkgfor a singleCRS.decode(...).toWKT(). With gpkg depending on it directly, excluding GeoTools' unused transitive jars from proj-gt alone would not have removed them from the WAR.Breaking changes:
ProjectionTransformerFactory.getWKT(int srid, boolean longitudeFirst)longitudeFirstforces x/y axis orderGPKGSpatialRefSystemsasks the collection's factory withlongitudeFirst = true*GeoPackage geometries are always x/y
hakunapi-gpkgno longer depends on GeoToolsJHeProjectionTransformerFactory(community) throws for now (have to fix that...)gt-epsg-hsqlexclusions inhakunapi-proj-gtURN_Parser,PROJFormatter,DefaultEntityResolver) are referenced only from GeoTools code paths hakunapi does not use: it decodesEPSG:<int>codes, transforms, and callstoWKT().Behaviour changes:
ProjectionTransformerFactoryimplementations must implementgetWKTdefaultimpl to throw, that way nothing breaks for anyone except if you're using customProjectionTransformerFactoryand using GPKG outputformathakunapi-proj-gt; an application relying on them transitively must declare them. Additionally, commons-lang3 also leaves the WAR once swagger-core's exclusions (Drop swagger-core's transitive dependencies from the servlet module #250) and these both are inhakunapi-tiles-generator(community) takes the CRS definition from the seeded collections' factory and bundleshakunapi-proj-gtat runtimeGPKGSpatialRefSystemscache is aConcurrentHashMap(was aHashMapmutated from concurrent requests)