Prepare v0.10.0-rc.2: fix rc.1 - #682
Merged
Merged
Conversation
Cherry-pick of the review fixes onto v0.10.0-rc.1. Package as PEP 440 0.10.0rc2. Do not publish as stable 0.10.0. Fail closed on unopened stream loads without clearing a live index, restore const searchKnnCloserFirst and addPoint(..., int level), stop CMake from wiping caller CMAKE_CXX_FLAGS, and make StatusOr/NoExceptions stream I/O avoid extra copies and throws.
ilyajob05
changed the title
ilyajob05
added a commit
to ilyajob05/hnswlib
that referenced
this pull request
Sep 14, 2026
Bring the rc.1 review fixes (PR nmslib#682) onto the SIMD/dialect line without rebasing published develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of the review fixes onto v0.10.0-rc.1.
Fail closed on unopened stream loads without clearing a live index, restore const searchKnnCloserFirst and addPoint(..., int level), stop CMake from wiping caller CMAKE_CXX_FLAGS, and make StatusOr/NoExceptions stream I/O avoid extra copies and throws.