Skip to content

fix(css): sidebar rendering - #992

Open
avivkeller wants to merge 1 commit into
mainfrom
fix(css)-sidebar-rendering
Open

fix(css): sidebar rendering#992
avivkeller wants to merge 1 commit into
mainfrom
fix(css)-sidebar-rendering

Conversation

@avivkeller

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings August 3, 2026 16:14
@avivkeller
avivkeller requested a review from a team as a code owner August 3, 2026 16:14
@cursor

cursor Bot commented Aug 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single CSS attribute selector change in generated UI styles; no runtime or security impact.

Overview
Fixes sidebar layout by updating the is-land selector in index.css from data-component='SideBar' to data-island-name='SideBar', matching how islands are marked in withIsland.jsx.

Without this match, the rule never applied (generic display: contents won), so the sidebar lost its flex column layout and aside flex growth.

Reviewed by Cursor Bugbot for commit 9e07c5e. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 3, 2026 4:15pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 30.0% slower (1.00 s → 1.30 s)
  • Peak memory: 0.8% lower (355.88 MB → 353.04 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 4.9% slower (19.27 s → 20.21 s)
  • Peak memory: 1.6% lower (2.22 GB → 2.18 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 2.7% slower (9.99 s → 10.26 s)
  • Peak memory: 5.9% lower (1.78 GB → 1.67 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 10.8% faster (9.05 s → 8.07 s)
  • Peak memory: 1.0% lower (1.72 GB → 1.70 GB)

orama-db Generator

Output size: 1 file changed · net +1.19 KB

File size details
File Main PR Change
orama-db.json 9.03 MB 9.03 MB +1.19 KB (+0.0%)

Performance estimate (single CI run)

  • Generation time: 29.3% faster (8.91 s → 6.30 s)
  • Peak memory: 3.5% lower (1.78 GB → 1.72 GB)

web Generator

Output size: 3 files changed · net -108.00 B

File size details
File Main PR Change
assets/style-DyC9tsk4.css 145.42 KB +145.42 KB
assets/style-C71voUGG.css 145.41 KB -145.41 KB (-100.0%)
all.html 31.41 MB 31.41 MB -112.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 1.3% slower (86.43 s → 87.55 s)
  • Peak memory: 3.4% lower (4.88 GB → 4.72 GB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants