Skip to content

fix(git-node): fix security release preparation#1126

Merged
RafaelGSS merged 3 commits into
nodejs:mainfrom
RafaelGSS:handle-affected-versions-map
Jul 27, 2026
Merged

fix(git-node): fix security release preparation#1126
RafaelGSS merged 3 commits into
nodejs:mainfrom
RafaelGSS:handle-affected-versions-map

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS requested a review from marco-ippolito July 25, 2026 20:00
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.47210% with 162 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.32%. Comparing base (c263c2a) to head (9351b62).

Files with missing lines Patch % Lines
lib/prepare_release.js 31.40% 83 Missing ⚠️
lib/landing_session.js 1.63% 60 Missing ⚠️
lib/cherry_pick.js 36.66% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   57.77%   57.32%   -0.46%     
==========================================
  Files          53       53              
  Lines       10197    10368     +171     
==========================================
+ Hits         5891     5943      +52     
- Misses       4306     4425     +119     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sometimes we need to include a commit that already
landed on `main` in a security release
@RafaelGSS

Copy link
Copy Markdown
Member Author

Just tested for the upcoming security release and it's working great!

@RafaelGSS
RafaelGSS merged commit eabfbde into nodejs:main Jul 27, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants