quic: fix broken listEndpoints export, test callbacks & nghttp3 include#63874
Open
pimterry wants to merge 1 commit into
Open
quic: fix broken listEndpoints export, test callbacks & nghttp3 include#63874pimterry wants to merge 1 commit into
pimterry wants to merge 1 commit into
Conversation
Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
This was referenced Jun 12, 2026
efekrskl
approved these changes
Jun 12, 2026
Qard
approved these changes
Jun 13, 2026
Member
|
Should we fast-track this? |
Contributor
|
Fast-track has been requested by @pimterry. Please 👍 to approve. |
pimterry
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63874 ✔ Done loading data for nodejs/node/pull/63874 ----------------------------------- PR info ------------------------------------ Title quic: fix broken listEndpoints export, test callbacks & nghttp3 include (#63874) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch pimterry:fix-quic-build-issues -> nodejs:main Labels c++, fast-track, needs-ci, quic Commits 1 - quic: fix broken listEndpoints export, test callbacks & nghttp3 include Committers 1 - Tim Perry <pimterry@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63874 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63874 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Jun 2026 11:04:07 GMT ✔ Approvals: 1 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63874#pullrequestreview-4491271009 ℹ This PR is being fast-tracked ✘ This PR needs to wait 145 more hours to land (or 25 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/27464811675 |
pimterry
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QUIC build & tests are broken on main in multiple ways:
#63860: The recent nghttp3 deps update (#63776) included internal changes which use _Generic (supported for C++ by Clang, but not by gcc). This only affects nghttp3 internals, but we had a dangling unused include which referenced them, so it broke things. We don't need these internals, and if we don't include them the problem goes away.
ListEndpoints (added in #63536) wasn't actually exported, so its tests fail on main. It clearly should be, it's included in the docs etc and used in the tests.
The new onSessionApplication callback (added in #63558) wasn't included in the setCallbacks test, which failed.
This PR drops the unused include, exports listEndpoints, and fixes the setCallbacks test.
It doesn't totally fix all QUIC build issues on main - there's one more, fixed already in #63821. That's an independent ngtcp2 deps issue (mergeable right now if anybody wants to add a 2nd approve there, or in a few days if not).
Independent of fix this, I'm now going to look to set up a CI job that builds & tests with
--experimental-quicto stop this happening again. I'll do that in another PR, watch this space.