-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
repl: add experimental TypeScript support #64077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avivkeller
wants to merge
7
commits into
nodejs:main
Choose a base branch
from
avivkeller:repl-ts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0552489
repl: add experimental TypeScript support
avivkeller 630ef3b
fixup!
avivkeller 4b27f79
fixup! q > p
avivkeller 218c3f8
fixup!
avivkeller 27abf1d
fixup!
avivkeller 208d746
fixup!
avivkeller cf6ff9f
Apply suggestion from @avivkeller
avivkeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Flags: --experimental-repl-typescript | ||
|
|
||
| import * as common from '../common/index.mjs'; | ||
| import assert from 'node:assert'; | ||
| import { startNewREPLServer } from '../common/repl.js'; | ||
|
|
||
| common.skipIfInspectorDisabled(); | ||
|
|
||
| const { run, output } = startNewREPLServer({ | ||
| terminal: false, | ||
| prompt: '> ', | ||
| }); | ||
|
|
||
| await run('let x: number = 3\n'); | ||
| assert.match(output.accumulator, /undefined\n> /); | ||
| output.accumulator = ''; | ||
|
|
||
| await run('x\n'); | ||
| assert.match(output.accumulator, /3\n> /); | ||
| output.accumulator = ''; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a multiline perspective, this approach will still only allow multiline input to be pure JS, as SWC InvalidSyntax errors will leave the input untransformed, and input containing TS-only syntax will then fail both JS execution and the Acorn recoverable parsing test.
The inconsistency would be really jarring, and I wonder if we need to just disable multiline in TS mode, and explicitly signpost users to
.editor.Alternatively, we could try and identify recoverable SWC InvalidSyntax errors from the initial strip attempt, but this would still have some inconsistencies with JS multiline. Truly unparseable partial input usually errors in SWC with some flavour of "unexpected eof", but there are cases like
const baz: stringwhose "stripped" JS equivalents are considered recoverable, but which SWC doesn't report in this way.