vm: enable interception on global restricted properties#64202
Open
legendecas wants to merge 2 commits into
Open
vm: enable interception on global restricted properties#64202legendecas wants to merge 2 commits into
legendecas wants to merge 2 commits into
Conversation
Original commit message:
[execution] Lookup interceptor for RestrictedGlobalProperty
When the script context looks up if a global property is
restricted, it should also query the global interceptor.
To avoid calling the interceptor for every declaration
unconditionally, an interceptor has to be defined with
`PropertyHandlerFlags::kHasDontDeleteProperty`
to intercept restricted global property queries.
Refs: nodejs#63715
Refs: nodejs#52634
Change-Id: I623ff285c4e8773d8ee7f681cbad68ba24bd3f40
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7898818
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108280}
Refs: v8/v8@a05321e
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
v8-vm-restricted-global
branch
from
93e842e to
e5fe063
Compare
joyeecheung
approved these changes
Jul 2, 2026
joyeecheung
left a comment
joyeecheung
left a comment
Member
There was a problem hiding this comment.
LGTM. I think this counts as semver-major?
joyeecheung
added
the
semver-major
Member
|
(Technically the V8 commit isn't semver-major) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deps: V8: backport a05321ebd98e
Original commit message:
Refs: v8/v8@a05321e
vm: enable interception on global restricted properties
Fixes: #63715