Update/Fix: fix-53867-test-runner - #64844
Closed
saitejabandaru-in wants to merge 1 commit into
Closed
Conversation
Currently the codebase for `runner.js` accesses some properties of `process`, capturing options there. However, since `run()` is exposed to end users, we should capture all this information in `lib/internal/main/test_runner.js` and pass it down to `run()` as options. This commit updates `run()` to default `cwd` to `.` instead of reading `process.cwd()`, and substitutes `process.execArgv` with the provided `execArgv` option when propagating V8 flags. It also updates `test_runner.js` to explicitly pass these options.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
|
@saitejabandaru-in We do not allow automated pull requests, as they violate the DCO. |
Author
|
I sincerely apologize for the automated pull request. It was triggered by an experimental agent framework testing open source contribution pipelines, and I completely missed that it violated the DCO and AI contribution guidelines for this repository. I am closing this PR immediately and have disabled the automation. Thank you for your patience and sorry for the noise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Pull Request to address fix-53867-test-runner. Please review.