Skip to content

embedder: return empty pointer without builtin snapshot #64845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Archkon wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

embedder: return empty pointer without builtin snapshot #64845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/api/embed_helpers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,13 @@ void EmbedderSnapshotData::DeleteSnapshotData::operator()(
}

EmbedderSnapshotData::Pointer EmbedderSnapshotData::BuiltinSnapshotData() {
return EmbedderSnapshotData::Pointer{new EmbedderSnapshotData(
SnapshotBuilder::GetEmbeddedSnapshotData(), false)};
const SnapshotData* snapshot_data =
SnapshotBuilder::GetEmbeddedSnapshotData();
if (snapshot_data == nullptr) {
return {};
}
return EmbedderSnapshotData::Pointer{
new EmbedderSnapshotData(snapshot_data, false)};
}

EmbedderSnapshotData::Pointer EmbedderSnapshotData::FromBlob(
Expand Down
3 changes: 2 additions & 1 deletion src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,8 @@ class EmbedderSnapshotData {

// Return an EmbedderSnapshotData object that refers to the built-in
// snapshot of Node.js. This can have been configured through e.g.
// --node-snapshot-main=entry.js.
// --node-snapshot-main=entry.js. If Node.js was built without a built-in
// snapshot, this returns an empty pointer.
static Pointer BuiltinSnapshotData();

// Return an EmbedderSnapshotData object that is based on an input file.
Expand Down
Loading