crypto: improve native error handling and key synchronization - #64851
Open
panva wants to merge 4 commits into
Open
crypto: improve native error handling and key synchronization#64851panva wants to merge 4 commits into
panva wants to merge 4 commits into
Conversation
Report DH failures instead of aborting or returning an empty secret. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Create the mutex before sharing key data so every copy uses one lock. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Return an operation error when XOF output allocation fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
jasnell
approved these changes
Jul 30, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64851 +/- ##
==========================================
+ Coverage 90.14% 90.16% +0.01%
==========================================
Files 746 746
Lines 242764 242773 +9
Branches 45739 45767 +28
==========================================
+ Hits 218848 218889 +41
+ Misses 15426 15365 -61
- Partials 8490 8519 +29
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 improvements in
src/crypto