ffi: support SharedArrayBuffer in getRawPointer - #64864
Open
ganjanggejang wants to merge 1 commit into
Open
Conversation
Signed-off-by: Junsoo Ha <junsoo2018@naver.com>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64864 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02%
==========================================
Files 746 746
Lines 242763 242764 +1
Branches 45761 45762 +1
==========================================
+ Hits 218848 218919 +71
+ Misses 15402 15322 -80
- Partials 8513 8523 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage and documentation for
ffi.getRawPointer()support forSharedArrayBuffer.getRawPointer()already supportedSharedArrayBuffersources, but this behavior was not covered by tests or documented.Note:
symbols.pointer_to_usize(sharedArrayBuffer)is not used in this test because it goes through the FFI pointer argument conversion path. The current implementation insrc/ffi/types.cconly handlesArrayBufferfor pointer arguments and does not supportSharedArrayBuffer.