test_runner: fix env option validation - #64865
Open
hanityx wants to merge 1 commit into
Open
Conversation
Signed-off-by: hanityx <hanityx@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64865 +/- ##
=======================================
Coverage 90.14% 90.15%
=======================================
Files 746 746
Lines 242763 242763
Branches 45761 45762 +1
=======================================
+ Hits 218848 218867 +19
+ Misses 15402 15393 -9
+ Partials 8513 8503 -10
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid values passed to
run({ env })currently throwERR_INTERNAL_ASSERTIONbecause the option name is missing from thevalidateObject()call.This passes
options.envto the validator so callers receiveERR_INVALID_ARG_TYPEinstead, and adds a regression test for invalidvalues.
Tests:
tools/test.py test/parallel/test-runner-run.mjs