http: normalize CONNECT request paths - #64876
Open
efekrskl wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Efe Karasakal <hi@efe.dev>
efekrskl
force-pushed
the
fix/http-connect-path-url
branch
from
July 31, 2026 16:37
987fc94 to
8172f67
Compare
nodejs-github-bot
added
http
anonrig
reviewed
Jul 31, 2026
|
|
||
| try { | ||
| validatePort(match[2], 'options.path', false); | ||
| const url = new URL(`http://${path}`); |
Member
There was a problem hiding this comment.
Suggested change
| const url = new URL(`http://${path}`); | |
| const url = URL.parse(`http://${path}`); |
anonrig
reviewed
Jul 31, 2026
| return false; | ||
| } | ||
|
|
||
| try { |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64876 +/- ##
==========================================
+ Coverage 90.14% 90.18% +0.03%
==========================================
Files 746 746
Lines 242763 242801 +38
Branches 45761 45774 +13
==========================================
+ Hits 218848 218963 +115
+ Misses 15402 15322 -80
- Partials 8513 8516 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34347
Partially a revival of #34412 which was apparently moving in the right direction but got stalled and closed