Skip to content

dns: validate address type in lookupService #64878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

dns: validate address type in lookupService #64878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ const {
validateNumber,
validateOneOf,
validatePort,
validateString,
validateStringWithoutNullBytes,
} = require('internal/validators');

Expand Down Expand Up @@ -269,6 +270,8 @@ function lookupService(address, port, callback) {
if (arguments.length !== 3)
throw new ERR_MISSING_ARGS('address', 'port', 'callback');

validateString(address, 'address');

if (isIP(address) === 0)
throw new ERR_INVALID_ARG_VALUE('address', address);

Expand Down
2 changes: 2 additions & 0 deletions lib/internal/dns/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ function lookupService(address, port) {
if (arguments.length !== 2)
throw new ERR_MISSING_ARGS('address', 'port');

validateString(address, 'address');

if (isIP(address) === 0)
throw new ERR_INVALID_ARG_VALUE('address', address);

Expand Down
18 changes: 18 additions & 0 deletions test/parallel/test-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,24 @@ assert.throws(() => {
}, err);
}

{
const invalidAddress = Buffer.from('127.0.0.1');
const err = {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: 'The "address" argument must be of type string. ' +
'Received an instance of Buffer'
};

assert.throws(() => {
dnsPromises.lookupService(invalidAddress, 0);
}, err);

assert.throws(() => {
dns.lookupService(invalidAddress, 0, common.mustNotCall());
}, err);
}

[null, undefined, 65538, 'test', NaN, Infinity, Symbol(), 0n, true, false, '', () => {}, {}].forEach((port) => {
const err = {
code: 'ERR_SOCKET_BAD_PORT',
Expand Down
Loading