ffi: fix crash in refCallback and unrefCallback - #64881
Open
trivikr wants to merge 1 commit into
Open
Conversation
Both handlers called fn.ClearWeak() and fn.SetWeak() without checking whether the persistent handle was still populated. After the callback function is garbage collected following an earlier unrefCallback() call, the handle is empty and both V8 methods dereference a null slot. InvokeCallback() already guarded against this. Add the same check to both handlers and throw ERR_INVALID_ARG_VALUE, matching the existing behavior for a pointer that is not in the callback map. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
ffi
mcollina
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
avivkeller
approved these changes
Jul 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64881 +/- ##
=======================================
Coverage 90.16% 90.17%
=======================================
Files 746 746
Lines 242763 242769 +6
Branches 45761 45772 +11
=======================================
+ Hits 218898 218913 +15
+ Misses 15352 15349 -3
+ Partials 8513 8507 -6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64880
Both handlers called
fn.ClearWeak()andfn.SetWeak()without checking whether the persistent handle was still populated. After the callback function is garbage collected following an earlierunrefCallback()call, the handle is empty and both V8 methods dereference a null slot.InvokeCallback()already guarded against this. Add the same check to both handlers and throwERR_INVALID_ARG_VALUE, matching the existing behavior for a pointer that is not in the callback map.Assisted-by: claude:opus-5