-
-
Notifications
You must be signed in to change notification settings - Fork 38k
src: compress ICU data into a shared cache file #66211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
34ea2c8
b094ea9
8afd2ef
465e71b
9ce7fe1
8e075c9
248ac4c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,7 +100,16 @@ | |
| ], | ||
| 'sources': [ | ||
| '<@(zstd_sources)', | ||
| ] | ||
| } | ||
| ], | ||
| 'toolsets': ['host', 'target'], | ||
| }, | ||
| { | ||
| 'target_name': 'zstd_compress', | ||
| 'type': 'executable', | ||
| 'toolsets': ['host'], | ||
| 'dependencies': ['zstd#host'], | ||
| 'include_dirs': ['lib'], | ||
| 'sources': ['../../tools/zstd_compress.cc'], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do wonder if bringing in a whole new implementation file is the best option. Isn't there any compression anywhere linked into node already? |
||
| }, | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -185,6 +185,8 @@ | |
| 'src/node_watchdog.cc', | ||
| 'src/node_worker.cc', | ||
| 'src/node_zlib.cc', | ||
| 'src/zstd_blob.cc', | ||
| 'src/zstd_blob.h', | ||
| 'src/path.cc', | ||
| 'src/permission/fs_permission.cc', | ||
| 'src/permission/permission.cc', | ||
|
|
@@ -659,6 +661,23 @@ | |
| 'WARNING_CFLAGS': [ '-Werror' ], | ||
| }, | ||
| }], | ||
| # The Release executable's local symbol table and STABS dominate | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems unrelated to ICU. |
||
| # LINKEDIT. -x drops local symbols and -S drops STABS. Debug keeps | ||
| # them. Do not pass -dead_strip: N-API and libuv symbols are reached | ||
| # only from addons loaded at runtime, and dead-stripping removes | ||
| # those exports from the executable. | ||
| ['OS=="mac" or OS=="ios"', { | ||
| 'configurations': { | ||
| 'Release': { | ||
| 'xcode_settings': { | ||
| 'OTHER_LDFLAGS': [ | ||
| '-Wl,-x', | ||
| '-Wl,-S', | ||
| ], | ||
| }, | ||
| }, | ||
| }, | ||
| }], | ||
| ['node_shared=="true" and OS=="win"', { | ||
| 'dependencies': ['generate_node_def'], | ||
| 'msvs_settings': { | ||
|
|
@@ -901,6 +920,9 @@ | |
| 'msvs_disabled_warnings!': [4244], | ||
|
|
||
| 'conditions': [ | ||
| [ 'icu_compress_data=="true"', { | ||
| 'defines': [ 'NODE_HAVE_EMBEDDED_ICU_ZSTD=1' ], | ||
| }], | ||
| [ 'openssl_default_cipher_list!=""', { | ||
| 'defines': [ | ||
| 'NODE_OPENSSL_DEFAULT_CIPHER_LIST="<(openssl_default_cipher_list)"' | ||
|
|
@@ -1671,6 +1693,9 @@ | |
| [ 'node_shared_libuv=="false"', { | ||
| 'dependencies': [ 'deps/uv/uv.gyp:libuv#host' ], | ||
| }], | ||
| [ 'node_shared_zstd=="false"', { | ||
| 'dependencies': [ 'deps/zstd/zstd.gyp:zstd#host' ], | ||
| }], | ||
| [ 'OS in "linux mac openharmony"', { | ||
| 'defines': ['NODE_JS2C_USE_STRING_LITERALS'], | ||
| }], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better done in the
if system-icubranch.