Skip to content

tools: pin sccache on all platforms to fix benchmark CI job - #66284

Open
pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:fix-benchmark-ci
Open

pimterry wants to merge 1 commit into
nodejs:mainfrom
pimterry:fix-benchmark-ci

Conversation

@pimterry

Copy link
Copy Markdown
Member

mozilla/sccache#2869 breaks sccache v0.18.0.

We pinned it back to avoid that in #66146, but just for Linux x64.

The benchmark job is now failing though, when using this same sccache version on aarch64-linux (https://github.com/nodejs/node/actions/runs/35988785748/job/107603726845) I think due to the same issue (I can't 100% confirm from the logs, but looks very likely: sccache v0.18 is used and fails to start) and further discussion in that sccache issue did confirm it's a cross-platform issue so that'd make sense.

Notably AFAICT there's no other jobs that do this combination of sccache-via-nix + aarch64-linux, which explains why it didn't come up before (the test-shared aarch64-linux job doesn't set with-sccache unlike the other platforms).

AFAICT we can safely just pin sccache for all platforms until it's fixed, and that seems like the simplest option.

Signed-off-by: Tim Perry <pimterry@gmail.com>
@pimterry
pimterry requested a review from aduh95 September 25, 2026 13:50
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 507 -> 507 => no changes 0 / 507 = 0.0%
aarch64-linux 508 -> 508 => no changes 1 / 508 = 0.1%
x86_64-darwin 445 -> 445 => no changes 0 / 445 = 0.0%
aarch64-darwin 450 -> 450 => no changes 1 / 450 = 0.2%
Total 1910 -> 1910 => no changes 2 / 1910 = 0.1%
Changelog
@@ -1692,0 +1693,2 @@
+/nix/store/g2gqhibqv6w58iz9287l1yr2zbjigs0y-sccache-0.17.0 (aarch64-darwin)
+/nix/store/v8y4nym7abc8f67blpmqbpwnm6nyi6a6-sccache-0.17.0 (aarch64-linux)
@@ -1694,2 +1695,0 @@
-/nix/store/cqywpjv4l1zfkqzmgi02r1z0kvx2fyai-sccache-0.18.0 (aarch64-darwin)
-/nix/store/pcw0wzcx1dc0f57rl2r7r0prc6yfwnfc-sccache-0.18.0 (aarch64-linux)

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants