module: centralize builtin exposure policies - #66292
Open
sjungwon03 wants to merge 1 commit into
Open
sjungwon03 wants to merge 1 commit into
sjungwon03 wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66292 +/- ##
==========================================
+ Coverage 90.35% 90.37% +0.01%
==========================================
Files 790 790
Lines 273814 274230 +416
Branches 52382 52490 +108
==========================================
+ Hits 247409 247823 +414
+ Misses 16906 16888 -18
- Partials 9499 9519 +20
🚀 New features to boost your workflow:
|
Keep scheme-only and option-gated builtin exposure rules in the JavaScript loader. Leave option registration and code-cache categorization with their native owners. Assisted-by: Codex Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03
force-pushed
the
refactor/module-builtin-policy
branch
from
September 25, 2026 22:23
767bbfb to
b2e6b82
Compare
daeyeon
reviewed
Sep 26, 2026
Comment on lines
+65
to
+67
| // Cover shared flags, both scheme rules, and an option enabled by default. | ||
| const workerPolicyIds = new Set([ | ||
| 'bench', 'bench/reporters', 'stream/iter', 'zlib/iter', 'sqlite', |
Member
There was a problem hiding this comment.
This list could become stale as policies change. For example, if these modules no longer need experimental flags while other modules still do, the test could pass without the coverage described above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builtin exposure rules are currently split between
realm.jsandseparate setup functions in
pre_execution.jsfor each option-gatedbuiltin.
Move the JavaScript loader's scheme and option-gating policies into one
table, and let pre-execution apply them after option initialization.
This intentionally keeps the policy in the JavaScript loader instead of
deriving it from native option registration. Native options do not
describe which builtins they expose: one option may enable multiple
builtins, while other options are unrelated to builtin exposure.
Code-cache categorization also has a separate responsibility. Adding
exposure metadata there would duplicate loader policy across the native
and JavaScript boundaries.
The policy test validates every declared builtin ID and option, as well
as defaults,
--no-experimental-*,NODE_OPTIONS, and command-lineprecedence. It also covers CommonJS, ESM, Workers, child processes, and
process.getBuiltinModule().A builtin omitted entirely from the policy table cannot be detected
automatically because there is no independent native mapping between
options and builtins. Centralizing the loader-owned policy reduces that
risk without introducing a second source of truth in C++.
Refs: #65418
Refs: #65964
Refs: #65920
Refs: #65840
Tests:
make -C out -j4 nodepython3 tools/test.py -j4 parallel/test-module-builtin-policies parallel/test-module-builtin-experimental parallel/test-sqlite