Conversation
nodejs-github-bot
added
c++
jasnell
approved these changes
Sep 25, 2026
When --process-timeout expires, --report-on-process-timeout asked every Worker for a subreport and waited without a time limit. A Worker blocked in a synchronous native call never answers, so the watchdog force-exited the process before the report was written. That left a truncated, invalid JSON file, and the forced-exit message was glued onto the "Writing Node.js report to file" line. For reports triggered by --process-timeout, wait at most two seconds for Worker subreports and leave out Worker threads that have not responded by then. The subreport state is now shared with the interrupt callbacks, so a Worker that answers late does not touch freed memory. Other report triggers are unchanged. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
trivikr
force-pushed
the
report-on-process-timeout-on-blocked-worker
branch
from
September 25, 2026 22:12
f5111e3 to
8c62c35
Compare
Member
Author
|
@jasnell I'd to force push after fixing a lint error. |
trivikr
added
the
request-ci
jasnell
approved these changes
Sep 25, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66304 +/- ##
==========================================
- Coverage 90.37% 90.36% -0.01%
==========================================
Files 790 790
Lines 274279 274284 +5
Branches 52506 52498 -8
==========================================
- Hits 247870 247859 -11
- Misses 16890 16903 +13
- Partials 9519 9522 +3
🚀 New features to boost your workflow:
|
trivikr
added
author ready
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66303
When --process-timeout expires, --report-on-process-timeout asked every Worker for a subreport and waited without a time limit. A Worker blocked in a synchronous native call never answers, so the watchdog force-exited the process before the report was written. That left a truncated, invalid JSON file, and the forced-exit message was glued onto the "Writing Node.js report to file" line.
For reports triggered by --process-timeout, wait at most two seconds for Worker subreports and leave out Worker threads that have not responded by then. The subreport state is now shared with the interrupt callbacks, so a Worker that answers late does not touch freed memory. Other report triggers are unchanged.
Assisted-by: claude:opus-5.5