Skip to content

test: deflake inspector close connection test - #66309

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:deflake-inspector-close-terminate-connections
Open

panva wants to merge 1 commit into
nodejs:mainfrom
panva:deflake-inspector-close-terminate-connections

Conversation

@panva

@panva panva commented Sep 26, 2026

Copy link
Copy Markdown
Member

Wait for NodeRuntime.waitingForDebugger before sending the resume command. Runtime.executionContextCreated does not guarantee that the child has started waiting for the debugger.

Refs: https://github.com/nodejs/node/actions/runs/36224832165/job/108356717128

Wait for NodeRuntime.waitingForDebugger before sending the resume
command. Runtime.executionContextCreated does not guarantee that the
child has started waiting for the debugger.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 26, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants