Skip to content

perf(cookies): split each cookie pair once in getCookies #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zirkelc wants to merge 1 commit into from
+8 −3
Closed

perf(cookies): split each cookie pair once in getCookies #5904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/web/cookies/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,14 @@ function getCookies (headers) {
}

for (const piece of cookie.split(';')) {
const [name, ...value] = piece.split('=')

out[name.trim()] = value.join('=')
// The name ends at the first '=', and the value keeps any later ones.
const index = piece.indexOf('=')

if (index === -1) {
out[piece.trim()] = ''
} else {
out[piece.slice(0, index).trim()] = piece.slice(index + 1)
}
}

return out
Expand Down