Repository navigation
Release 1.6.10: five fixes from an outside review, and a staged install - #36
Merged
Merged
Conversation
noderaven
force-pushed
the
release-1.6.10
branch
from
October 17, 2026 23:25
256aba0 to
0852959
Compare
noderaven
force-pushed
the
release-1.6.10
branch
from
October 17, 2026 23:37
0852959 to
d5a73e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.6.10: five fixes from an outside review of 1.6.9, and a staged install.
An outside review of 1.6.9 found five defects and reproduced each with an offline script against the built helpers; all five reproduced again here before the fixes and were traced in the code.
pythoninto shell words (shlex.split), while the run quotes the whole path, so a Windows user folder with a space failed doctor's Python check and stopped the launch. Doctor now runs it as one path; a quoted value fails with the reason.src/) covers the paths under it in task-checks, but lane validation, join waves and the owner map compared exact strings. One rule now holds everywhere: two paths overlap when equal or when one is a folder holding the other. derive-lanes groups such tasks so it does not propose a split validation refuses.budgetstop. It is now advisory: one call, no retry, no availability probe, and no refusal latch.task_checksentry for a lane with no test, lint or build command was accepted but never ran; validation now reports it.AandBruns as unitA-B, which a real taskA-Bcould collide with; validation now rejects any colliding batch unit id, including part of a batch and other batches, in any letter case.Also:
install.shremoved the installed skill before copying the new one, so a failed copy left none, and it copied untracked files from the checkout. It now stages the copy outsideskills/, checks it, swaps it in (restoring the old one if the swap fails), and from a git checkout copies tracked files only.Every fix has a test that failed first. Full suite on Windows (Python 3.15) at the release head: 1881 tests, 1865 pass, 16 skipped, 0 fail. Built directly; 1.6.9 was released but not installed, and this release includes it.