Repository navigation
Give newer/older links a fixed left/right position - #25
Merged
Merged
Conversation
Previously both links (when both existed) were just concatenated in a <p>, so which one appeared on which side depended on which existed - and with only one link, its horizontal position wasn't fixed at all. Now uses the same three-columns/six-columns/three-columns row layout as the blog-post template's own previousPost/nextPost navigation: "newer" always bottom-left (with a left arrow), "older" always bottom-right (with a right arrow), with an empty column when the corresponding link doesn't apply on that page - so the position never shifts depending on which links happen to be present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously both links (when both existed) were just concatenated in a
, so which one appeared on which side depended on which existed - and with only one link, its horizontal position wasn't fixed at all. Now uses the same three-columns/six-columns/three-columns row layout as the blog-post template's own previousPost/nextPost navigation: "newer" always bottom-left (with a left arrow), "older" always bottom-right (with a right arrow), with an empty column when the corresponding link doesn't apply on that page - so the position never shifts depending on which links happen to be present.