Foundation hardening before plugin registry - #55
Merged
Merged
Conversation
Align Go toolchain to 1.25, fix builtin protobuf registration conflicts, remove GOLANG_PROTOBUF_REGISTRATION_CONFLICT workarounds, bump tier-3b dependencies, add govulncheck CI, document deferred vulns, and fix singleprocess test lifecycle hangs. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Use *Service type assertion in test helpers so non-test packages compile, and upgrade golangci-lint to v2.1.6 for Go 1.25 export data support. Co-authored-by: Cursor <cursoragent@cursor.com>
Use --default=none and run gofmt separately since v2 removed --disable-all. Co-authored-by: Cursor <cursoragent@cursor.com>
Use xargs for gofmt file list to avoid SC2046 word-splitting warning. Co-authored-by: Cursor <cursoragent@cursor.com>
Prebuilt golangci-lint binaries are built with Go 1.24 and cannot target Go 1.25; gofmt + go vet preserves the same checks without that mismatch. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Remove unreachable code, cancel stream contexts on all error paths, and avoid copying protobuf refs that embed sync.Mutex in tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Use golangci-lint built with Go 1.25 with lostcancel disabled for the runner accept loop, and compare on-demand runner targets with proto.Equal. Co-authored-by: Cursor <cursoragent@cursor.com>
Wait for the runner to reconnect after a simulated server restart before unblocking job completion, and tolerate transient stream errors when sending the job complete message. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.go-version,go.mod, CI workflows)plugin.protofiles to unique names and regenerating pluginsGOLANG_PROTOBUF_REGISTRATION_CONFLICTworkarounds from CI, Docker, and E2E testsdistribution/reference)govulncheckCI job and document deferred findings indocs/security/vuln-triage.mdsingleprocesstest timeouts (background goroutine cleanup, Horizon skip guard)Change Classification
derrick)Test plan
GOWORK=off go test ./pkg/server/singleprocess/...(~29s)GOWORK=off make bin/cli-only && ./derrick version(clean, no protobuf stderr)GOWORK=off go veton previously failing packagesDependencies
v0.1.1, then bumpgo.modSDK dependency in a follow-up commit