Repository navigation
Sync browser web storage with profiles - #149
Conversation
|
@greptile review |
[Critical impact] The PR appears safe to merge; no new actionable issues were found.
|
|
@greptile review |
|
@greptile review Added live Unicode rejection, concurrent WAL and compaction coverage, source-change detection, and redirect/error redaction tests for the legacy cookie upload. Unscoped disk cookie-only snapshots, including empty storage tables, keep the existing cookie endpoint. Scoped cookie-only and live snapshots intentionally use the state endpoint to preserve unrelated saved state. The final request-size check runs before profile creation. The full race-enabled suite and lint pass. |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
@greptile review |
|
@greptile review |
profiles syncnow transfers localStorage as well as cookies, including storage-only logins.--cdp-urlalso captures sessionStorage from open Chromium tabs while preserving saved storage for closed tabs.Scoped sync preserves other sites, including for cookie-only snapshots. Incomplete or oversized snapshots fail before profile creation, and uploads refuse redirects. Requires
POST /profiles/{id}/state; older servers return an explicit unsupported-server error. IndexedDB, partitioned storage and device-bound credentials remain unsupported.Updated against current main without changing sync behavior. New integration cases exercise authenticated storage-only and mixed imports with synthetic browser data and temporary profiles. Both passed against staging. The existing payment sandbox test now requests a vault-backed session, matching the fixture correction already verified in #157.
Validation: current-head CI passes, including the full staging integration suite, both storage-import cases, payment sandbox lifecycle, build/lint, credential stores, installation and skill installation. Greptile approved the current head at 5/5. Local Go 1.25.5 race tests, generated-code stability, endpoint/skill guards and all six release builds also pass. Both changed integration tests compile and pass changed-code lint. Integration-tag lint additionally reports five existing errcheck issues in unchanged functions tests.