Skip to content

Keep session capture flags compatible with older APIs #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreakiro merged 1 commit into from
Oct 27, 2026
Merged

Keep session capture flags compatible with older APIs #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/cmd/sessionstart_flags.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/cmd/sessionstart_flags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func TestCaptureFlagsPreserveFalseAndOmission(t *testing.T) {
field = "log_session"
}
got, present := payload[field]
if present != (value != "") {
if present != (value == "false") {
t.Fatalf("%s presence=%v", field, present)
}
if present && got != (value == "true") {
Expand Down
7 changes: 6 additions & 1 deletion scripts/gen-flags/codegen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,12 @@ func generateSimpleFieldMapping(buf *bytes.Buffer, fc *FieldConfig) {

if fc.Field.Type == "boolean" {
// For booleans, check if flag was changed
fmt.Fprintf(buf, "\tif cmd.Flags().Changed(\"%s\") {\n", fc.FlagName)
if fc.Field.Name == "record_session" || fc.Field.Name == "log_session" {
// Both API generations capture by default; only opt-outs need a field.
fmt.Fprintf(buf, "\tif cmd.Flags().Changed(%q) && !%s {\n", fc.FlagName, fc.VarName)
} else {
fmt.Fprintf(buf, "\tif cmd.Flags().Changed(\"%s\") {\n", fc.FlagName)
}
fmt.Fprintf(buf, "\t\tbody.%s = %s\n", apiFieldName, assignOp)
buf.WriteString("\t}\n\n")
} else if fc.Field.Required {
Expand Down
Loading