[giordano-lucas]

What

observe() describes the controls above and below the viewport without an id, so a reader knows they exist and can scroll to them. That only looked at the page viewport. A control scrolled out of a small scroll box that is itself in view was neither in view nor below the fold, so it vanished. On uitestingplayground.com/overlapped, "Subject" sits below the visible part of a 100 px overflow-y: scroll box and was missing from the observation.

Controls whose center is above or below the box of an ancestor that scrolls vertically (and that they don't escape by positioning) are now described like the controls below the fold: no id, offered once scrolled into view. Only vertical scrolling counts, as for the page. Boxes that clip without scrolling keep hiding what they clip, as before.

Text rows scrolled out of a box (not controls) are unchanged.

Example

<div style="height: 100px; width: 300px; overflow-y: scroll">
  <input placeholder="Id" style="display: block">
  <div style="height: 150px"></div>
  <input placeholder="Subject">
</div>

Before (main), the Subject field below the box's visible area is missing:

I1[:]<input placeholder="Id"></input>

After, it is described without an id, like a control below the fold:

I1[:]<input placeholder="Id"></input>
_[:]<input placeholder="Subject"></input>

Tests

• tests/browser/test_dom_offscreen_controls.py: 9 passed on Python 3.15.1 with locked Patchright 1.64.1. Covers scrolling shadow hosts, controls behind both borders of plain and scaled scroll boxes, and becoming actionable after scrolling.
• Pre-commit passed for the changed files, including its pinned type checker.
• No golden or characterization snapshots changed. GitHub CI is validating the rebased head.

Bench

The bench ran before the last rebase, on a local build of feat-session-act with the coverage tasks and all the observe fixes of this series merged (one build; each task below exercises one fix). Base is the same build without the fixes. Jev, 2 runs each, base and head back to back, concurrency 2, load average 28–40 on a shared machine.

task / probe	base	head
uitap-overlapped	0/2	2/2, with the covered-field fix; this PR adds Subject as an off-screen field

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: nottelabs/notte
• Branch: fix-observe-inner-scroller-offscreen
• File: .coderabbit.yaml
• Commit: 89687cf
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 24bbdfba-06e4-4fed-9514-e65e0675e3de

Commits

Reviewing files that changed from the base of the PR and between b122d73 and 89687cf.

Files selected for processing: 3

• AGENTS.md
• packages/notte-browser/src/notte_browser/js/buildDomNode.js
• tests/browser/test_dom_offscreen_controls.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

Controls scrolled above or below a scroll box now remain in observations without action IDs.

• Scroll-box controls appear in the page description before they are visible.

All three earlier findings are addressed in the current code. No new actionable issues were found.

_{Reviews (3) · Last reviewed commit: "fix(observe): preserve actions in escapi..." · Reviewed by Greptile}

[github-actions]

Warning

Your comment is too long (maximum is 65536 characters), so the coverage report was not added. See the job log for how to reduce it.

Tests	Skipped	Failures	Errors	Time
3430	6 💤	0 ❌	0 🔥	5m 19s ⏱️

[giordano-lucas]

@greptile review

[giordano-lucas]

@greptile review