[giordano-lucas]

The cloned-header regression from #1356 never entered its MutationObserver branch, because production no longer sets bridge marker attributes. Inject a test marker after the real listener probe, assert that both inspected headers are cloned, and verify that the detached handles do not make their listener-free replacements actionable. Clicking the cloned Due header must leave the table unsorted. Keep the marker and temporary-global cleanup assertions.

Production DOM evaluation is unchanged. On locked Patchright 1.64.1, main-world element handles retain their DOM identity in isolated evaluation, and the actual header observation succeeds.

Validation: the new clone-count assertion fails on the old test setup (0 instead of 2); all six header-listener browser regressions pass after the repair. Pinned pre-commit checks, full-project typing, and Python 3.11 syntax checks pass.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by CodeRabbit

• Tests
  • Expanded browser coverage for header cloning and replacement, verifying that replacement headers do not trigger sorting and that temporary test markers are cleaned up.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: nottelabs/notte
• Branch: test/header-clone-observer
• File: .coderabbit.yaml
• Commit: 82021ea
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 53ff3708-7f2d-4b37-83e7-a19db634b58f

Commits

Reviewing files that changed from the base of the PR and between 6b34e66 and 82021ea.

Files selected for processing: 2

• AGENTS.md
• tests/browser/test_dom_header_click_listeners.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

Walkthrough

The browser test now injects a temporary marker during header-listener inspection and tracks cloned headers. It verifies that observation offers no actions after the headers are replaced, and that clicking a replacement header does not sort. The test also checks cleanup of temporary DOM attributes and globals. The AGENTS.md guidance describes the marker timing and assertions.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Minimal · up to 82021

No actionable merge risk remains after the test-marker concern was refuted.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surv…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies a browser regression test for the cloned-header observer behavior, which matches the main change.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Repairs the cloned-header browser test without changing production code.

• The header clone test now exercises replacements after listener inspection.

_{Reviews (1) · Last reviewed commit: "test(browser): exercise header clone obs..." · Reviewed by Greptile}

[github-actions]

Warning

Your comment is too long (maximum is 65536 characters), so the coverage report was not added. See the job log for how to reduce it.

Tests	Skipped	Failures	Errors	Time
3596	6 💤	0 ❌	0 🔥	5m 29s ⏱️