Skip to content

Repository navigation

docs: record the filed Codex feature request in the patch record #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
novelKR merged 1 commit into from
Oct 12, 2026
Merged

docs: record the filed Codex feature request in the patch record #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/ko/upstream-lock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ CodeSpace는 [고정 버전의 Codex 수정 정책](upstream-patches.md)에 따
| CodeSpace 사용 | 관리 대상 PTY 실행([CSRG-U5](devguard-integration.md#devguard-lifecycle)). PTY 어댑터의 `spawn_observed`가 CodeSpace의 관찰 상한(2초)으로 관찰자를 등록하고, 그 창에서 DevGuard의 `Observe`가 reap 전에 이루어짐. 관리하지 않는 PTY 실행은 여전히 `spawn_pty_process`를 호출함 |
| 출처 | W3 실험 B의 관찰자([DevGuard 결정 패킷 3.2절](https://github.com/novelKR/DevGuard/blob/668750b4ab6ad582904c3d05ffceffa062b26243/docs/handoff/2026-09-28-w3-decision-packet.md#32-experiment-b-backend-owned-pre-reap-observation-packet-132))를 이 릴리스의 두 Unix PTY 경로로 옮긴 것. 수정한 파일마다 CodeSpace 수정 고지가 있음(Apache-2.0 4(b)) |
| 검증 | 패치 적용 tree에서 함. Linux x86_64: crate 테스트 36개를 30회 반복해 모두 통과. macOS: 테스트 38개를 30회 반복해 모두 통과, DevGuard `6e7e065`로 W3 실험 B의 B1-B13 통과. Linux, macOS, Windows 대상 clippy 통과 |
| 업스트림 | Codex는 외부 pull request를 받지 않음. 기능 요청 초안만 있고 제출하지 않음 |
| 업스트림 | Codex는 외부 pull request를 받지 않음. 기능 요청 [openai/codex#53298](https://github.com/openai/codex/issues/53298)을 2026-10-12 소유자 승인으로 제출함 |
| 제거 조건 | Codex 릴리스가 같은 관찰(단일 waiter, bound, 결과 보고)을 제공하고 CodeSpace가 그것으로 옮기거나, CodeSpace가 더 이상 회수 전에 PTY 실행을 관찰하지 않으면 패치를 뺌 |
| 핀 변경 시 | 패치를 되돌리고 서브모듈을 옮긴 뒤, 후보에 패치를 다시 옮기거나 제거 조건에 따라 빼고, Linux와 macOS에서 테스트를 다시 실행하고 이 기록을 갱신 |
| 되돌리기 | CodeSpace의 관찰자 사용을 먼저 되돌린 뒤, 패치 파일과 이 기록을 함께 되돌림 |
Expand Down
4 changes: 2 additions & 2 deletions docs/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,8 +649,8 @@
"하위-패치",
"확인과-갱신"
],
"source_sha256": "55964a2fefa072c9f4642f667a98195a4ad7213b0dc76b1368d44eecbcafe640",
"translation_sha256": "ef64b2a6158b7cbd7956243620d6af4ec7557d07e31b59e9a6c78b394ea8bec0"
"source_sha256": "5a850ffa3d315d739c5fc3e35ba9ada1a9709e651915632264ea12851ab03087",
"translation_sha256": "17ab2bb0858c4f8521d31a49e1648f43bddaaaa27240fba5bf501f7a2c4ecc82"
},
{
"id": "upstream-update",
Expand Down
2 changes: 1 addition & 1 deletion docs/upstream-lock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ CodeSpace carries one patch to `codex-utils-pty`, under the [policy for changing
| Use in CodeSpace | governed PTY executions ([CSRG-U5](devguard-integration.md#devguard-lifecycle)): the PTY adapter's `spawn_observed` registers an observer with CodeSpace's observation bound (2 s), and its window carries DevGuard's `Observe` before the reap. Ungoverned PTY executions still call `spawn_pty_process` |
| Provenance | ported from the observer of W3 experiment B ([DevGuard decision packet, section 3.2](https://github.com/novelKR/DevGuard/blob/668750b4ab6ad582904c3d05ffceffa062b26243/docs/handoff/2026-09-28-w3-decision-packet.md#32-experiment-b-backend-owned-pre-reap-observation-packet-132)) to both Unix PTY paths of this release. Each modified file carries a CodeSpace modification notice (Apache-2.0 section 4(b)) |
| Verification | on the patched tree: Linux x86_64, the crate's 36 tests in each of 30 runs; macOS, its 38 tests in each of 30 runs and W3 experiment B's cases B1-B13 against DevGuard `6e7e065`. Clippy is clean for Linux, macOS and Windows targets |
| Upstream | Codex accepts no external pull requests. A feature request is drafted and not submitted |
| Upstream | Codex accepts no external pull requests. Feature request [openai/codex#53298](https://github.com/openai/codex/issues/53298), filed on 2026-10-12 with the owner's approval |
| Removal | drop the patch when a Codex release offers an equivalent observation (one waiter, a bound, an outcome) and CodeSpace moves to it, or when CodeSpace no longer observes PTY executions before the reap |
| Pin changes | revert the patch, move the submodule, then port the patch to the candidate or drop it under the removal condition; rerun its tests on Linux and macOS and update this record |
| Rollback | revert the patch file and this record together, after reverting any CodeSpace use of the observer |
Expand Down
Loading