Repository navigation
fix(ci): probe default images by digest, not tag@digest (D-0264) - #664
Merged
Merged
Conversation
docker manifest inspect repo:tag@digest fetches the tag and then checks the result against the digest. When upstream moves a floating tag (python:3.12-slim, mailpit:latest) the check fails with "manifest verification failed for digest" even though the pinned digest still exists and still pulls; a pull of repo:tag@digest ignores the tag. Probe repo@digest instead, fail loudly on a lock entry with no digest, and probe the mirror by digest too. Reproduced locally: the tag@digest form returns rc=1 for python 05cda977, the repo@digest form returns rc=0; the fake 1111... digest still fails. Refs #602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The scheduled Default images pullable check went red on main (runs 38046978745, 38135117026; issue #602) for
python:3.12-slimandmailpit:latest. Neither image is broken.docker manifest inspect repo:tag@digestfetches the tag and then checks it against the digest. Once upstream moves a floating tag, that check fails withmanifest verification failed for digest, even though the pinned digest still exists and a pull ofrepo:tag@digest(which ignores the tag) still works. The weekly pin-bump branch passed because it carries fresh digests.Local repro:
docker.io/library/python:3.12-slim@sha256:05cda977…manifest verification failed)docker.io/library/python@sha256:05cda977…docker.io/library/alpine@sha256:1111…(fake)no such manifest)What
repo@digest(tag stripped, registry/port-safe).@digest.nself/<service>@digest, same reason.Lock and pins are unchanged. Tag drift stays the job of the weekly pin-bump PR (#617, left for the owner).
IMAGE_MIRROR_APPLYis untouched.Refs #602, D-0264.