Repository navigation
fix(nginx): fronted projects emit TLS only when the serving stack holds the cert pair (D-0572) - #901
Merged
Merged
Conversation
…ds the cert pair (D-0572) A project with NGINX_FRONTED_BY is served by the fronting stack's nginx, which mounts its own ssl/. The TLS decision read the project's own ssl/ (or assumed true in local mode), so site confs and plugin snippets could name a certificate the serving nginx cannot load. Check the pair in nginxtopo.ServedSSLDir for every mode but none. A shared-proxy owner keeps the existing flow, where the build copies the pair in.
…y owner (D-0572) internal/nginx must not import internal/sharedproxy (same-layer edge). nginxtopo owns the owner-file path; sharedproxy re-exports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes D-0572.
A project with
NGINX_FRONTED_BYis served by the fronting stack's nginx, which mounts its ownssl/. The TLS decision (sslShouldEmit) read the project's ownssl/or assumed true in local mode, so site confs and plugin snippets could name a certificate the serving nginx cannot load.none, a fronted project now needs the pair innginxtopo.ServedSSLDir; without it the confs are HTTP-only and TLS plugin snippets are skipped with the existing warning.NGINX_MODE=shared) keeps its flow: the build copies the pair into the owner's ssl itself, so the old rule applies.Verified: gofmt clean, go vet, go test of internal/nginx and internal/build.