Repository navigation
fix(ssl): ssl add leaves no rejected nginx conf; ACME first conversion rolls back; prepare errors are E471 (D-0412) - #903
Merged
Merged
Conversation
…d first conversion, tag prepare errors as install failures (D-0412) ssl add (certbot and --acme) snapshots custom-<domain>.conf before writing it and puts it back when nginx -t or the reload rejects it, so the next restart still starts. The first ACME conversion of a real directory renames it back when the symlink switch fails. Errors from preparing a generation carry ErrInstall so they answer E471.
…r restored (D-0412)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the cli items of D-0412 (the harness item landed in plugins#161).
Tests: TestACMEFirstConversionFailure (restore + E471), TestConfSnapshotRestore (new and existing conf), TestSSLAddACMENginxRejectsConf (end to end). The first fails before the fix on both assertions; the last fails with the restore call removed. gofmt clean; go vet ./cmd/commands ./internal/ssl/... and go test -race ./internal/ssl/... ./cmd/commands/ pass.