Repository navigation
fix(docker): RunOneShot removes its container on cancel (D-0712, D-0724) - #904
Merged
Merged
Conversation
…ancelled (D-0712, D-0724) Each one-shot now has a container name (the caller's or a generated one). When the context ends by signal or deadline, the named container is removed with docker rm -f in its own process group, so db export, backup, restore and pg_restore stop writing to the target after nself reports failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes debt rows D-0712 and D-0724.
RunOneShot only killed the docker client on ctx cancel, so the pg_dump/pg_restore container kept running against the database. Every run now carries a container name (caller-set or generated) and a cancelled run force-removes it (own process group, 30 s bound).
Tests: fake docker that blocks on run; asserts rm -f for generated and caller-set names, none on success. Mutant (drop the removal) fails the test.