Repository navigation
fix(build): the minio plugin fragment joins a project's stack only with MinIO intent (D-0702) - #910
Merged
Conversation
…th MinIO intent (D-0702) The minio plugin is installed machine-wide, so in v1.5 every project built on the machine got a <project>_minio container with an empty volume, and two running projects clashed on 127.0.0.1:9000. Plugin discovery now takes a project filter; compose.PluginFragmentWanted keeps the fragment out unless ActiveStore picks the plugin. v1.4 output is unchanged (compat marker).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes debt row D-0702.
The minio plugin is installed machine-wide (~/.nself/plugins). In v1.5 every project built on the machine merged its compose fragment: a _minio container with an empty volume even with MINIO_ENABLED=false, and two running projects clashed on 127.0.0.1:9000.
Fix: plugin discovery takes a project filter;
compose.PluginFragmentWantedleaves the minio fragment out unlessActiveStorepicks the plugin (v1.5 with MinIO intent). v1.4 output is unchanged, behind acompat.V15(P7-PLUG-60)marker; the Compat-V15 wiki table is regenerated. Other plugins merge as before.Test: real
Buildover a plugin dir with minio and a control plugin, v1.4/v1.5 x intent on/off, reading the written compose manifest. Two mutants (predicate returns true; wiring removed) fail the v1.5 intent-off case.