Repository navigation
test(v15): run cmd/commands in the NSELF_V15=1 CI step; pin or fix its v1.4-only tests (D-0275, partial) - #912
Merged
Merged
Conversation
…5=1 and run the package in the v1.5 CI step (D-0275) Fifteen tests assert v1.4 behaviour and now pin it with compattest.Set; four config set tests get a fake sysexec runner; jsonEnvelopeOn answers off for a nil command, which runBundleList accepts (the four bundle list tests panicked). The legacy-spelling test pins v1.4 because Execute() under v1.5 reshapes the shared root command and broke every registration test after it. The v1.5 CI step now runs the whole module; thirteen cmd/commands tests that fail only after env-leaking loader tests stay on its skip list.
… positive control (D-0275)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of D-0275 (the row stays open for the leftover below).
Found by running every cmd/commands test alone under NSELF_V15=1, then the whole package:
Left on the skip list: 13 tests (WriteResolvedDeployEnv, EnvCascade, Snapshot, Scratch families) that pass alone but fail after earlier tests that load a project .env and leave its keys in the process env; v1.5 remote deploy then refuses them as process-only keys. Bisect: culprits are TestBackupStatusInProjectKeepsExistingFields and TestBackupScheduleProdMinioCredentials among others.
Verified on the CI host: NSELF_V15=1 go test with the CI skip list ./cmd/commands and the default-mode ./cmd/commands both pass; go vet and gofmt clean.