Repository navigation
Merged
Conversation
…des (D-1146) default.conf.bak and other non-.conf files under nginx/conf.d*/ and nginx/sites/ are never loaded by nginx (nginx.conf.tmpl includes only *.conf), so they no longer keep the generated default.conf off the host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-1146 — fixed
KeptHostConfDscannednginx/conf.d*/* nginx/sites/*fordefault_server, so a backup such asdefault.conf.bak(never loaded by nginx;nginx.conf.tmplincludes only*.conf) kept our generateddefault.confoff the host. The glob is nownginx/conf.d*/*.conf nginx/sites/*.conf.Test: two new cases in
TestKeptHostConfDDefaultServerCollision(default.conf.bak,sites/other.conf.orig). Both failed before the fix, pass after.D-0133 — not changed (BLOCKED)
Still applies on origin/main: the
functionscommands (cmd/commands/functions*.go) and the compose wiring (internal/compose/core_services.go) are both still in core. The resolution moves the service into the plugin (ADR 0028 pattern), which is plugin-repo work owned by P7-PLUG, not a local fix.D-0111 — not changed (BLOCKED)
Still applies:
internal/embedded/andcmd/commands/start_embedded_cgo.goexist, issue #231 is open. The row asks for a product decision (finish dynamic linking behind an experimental flag, or remove the package and start hook); that is not mine to make.Commands run
go build ./...okgo vet ./internal/deployok;gofmt -l internal/deployemptygo test ./internal/deploy: 322 passed