Repository navigation
Merged
Conversation
… parsers, drop the copies and the drift test (D-0422)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small debt rows, one commit each. D-0429 is not touched (see below).
Rows
internal/dockernow exportsParseServiceSpecsandParseContainerStates.internal/deploycalls them:decodeContainerStatesis deleted,parseComposeModelgets its specs fromdocker.ParseServiceSpecsand decodes only the extra fields it needs (image, container name, mounts, network aliases). The exporteddocker.HealthTimeoutwrapper existed only for the copy, so it is removed.TestCopiedParsersMatchDockeris deleted, since there is one implementation now. The existingparseComposeModeland RemoteStates tests still cover the deploy side.rminrcand ends withexit $rc, so an early failure is no longer hidden by a later success. New testTestPrunePreDeployTarsReportsAnEarlierRmFailureputs a stubrmon PATH that fails for the first tar in drop order (03, then 02 and 01 succeed). It fails on the old loop ("a failed rm was reported as a clean prune") and passes with the fix.scripts/e2e/proxy-swap.sh, a build that had already exited when killed is nowFAIL(exit 1) instead of a WARN followed by PASS. Not run here: needs Docker and the e2e fixtures (see below).scripts/e2e/multi-app-isolation.shmints a token for a real app_a member ($UA) that claims app_b, and for bothnotesandprojectsasserts it reads 0 rows, cannot insert (permission-error) and leaves app_b's row count at 2. The metadata permission checksapp_memberson user id and claimed app, so the expected result holds by design. Not run here (Docker)..env.<cascade>snapshot is a compose env input, and is scheduled under P7-DEPL-24 (debt triage: "needs a lead ruling in the DEPL Invalidations"). No code change.Checks run
gofmt -l internal: cleango vet ./internal/deploy/... ./internal/docker/...: cleango test ./internal/deploy/... ./internal/docker/... -count=1: 686 passedgo build ./...: okbash -non both e2e scripts: ok