Repository navigation
Conversation
…s directory names; install clears a stale remove intent (D-0662)
…date page (D-0751)
…der --json; guides pass --yes to rollback (D-0762)
… runs to cut the package run time (D-0735)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five low debt rows. No hq edits, no version bumps, no release.
D-0662 (fixed)
plugin.checkReverseDependenciesnow returns plugin directory names (was manifest names) and reports aplugin.jsonthat exists but cannot be read or parsed as*UnreadableManifestsErrorinstead of skipping it. Dot-prefixed folders and.prevbackups are not scanned for unreadable files.plugin removerefuses (hint: fix it or--force) when another plugin's manifest is unreadable.bundle remove(keepDependedOn) refuses before removing anything when an outside plugin's manifest is unreadable; an unreadable manifest of a planned member does not block (broken members stay removable). Dependents compare by directory name, so a manifest name equal to a planned member in another directory no longer counts as planned.bundle installclears that bundle's stale remove intent when the ledger is recorded (a failed clear is a warning, other bundles' intents untouched).Bundles.mdgains the Resume and Kept-for-a-dependent bullets;cmd-bundle.mdmentions the refusal and the clear.reverse_deps_test.go,remover_deps_unreadable_test.go,installer_intent_test.go. The directory-name test fails against the oldm.Namereturn (checked by temporarily reverting that line).D-0751 (fixed)
cmd-config.mdvalidate PROSE block now describes the unquoted/double-quoted$warning (file, line and key only, never the value;${NAME}not flagged; stderr only, no exit-code or--jsonchange).make cmd-inventoryandmake wiki-checkclean.D-0762 (fixed)
--jsonis now recorded withoutput.AddDeprecation(oldnself <path> without --yes, newnself <path> --yes, removalv1.5.0), also when the stderr line is silenced. Test:TestDataLossGateJSONDeprecation.cmd-migrate.md,Upgrade-From-v0.9.md,Upgrading-from-v1.md: rollback examples pass--yes, plus a note on the v1.5 E403 refusal off a terminal.D-0735 (fixed, by cutting test time; timeout not raised)
Profiled
go test -json ./cmd/commandslocally (270s; the Intel runner takes 334s, 2.4x the other legs). Causes: fourgo build ./cmd/nselfper package run, andTestPilotJSONUnderV15Guardre-running the subprocess "live" subtests that ignore itst.Setenv(runPilotrebuilds the child environment).pilotBinary(t)(one build).TestSurfaceIdentitykeeps its own build: it runs in a fresh process.TestCommandsTestsShareOneNselfBuild(fails if a cmd/commands test builds./cmd/nselfitself).TestDBHasuraNoEnvSyncApplyRefLocalGolden/sync(15s), not investigated.D-1165 (fixed)
proxy-swap-e2e.yml: the Round-trip and Kill-mid-remove steps now run onpull_requestas well as the dispatched round-trip leg. Test:TestProxySwapRecoveryLegsRunOnPullRequests(fails on the old workflow). Prior PR runs take about 7 minutes for add + renew, so two more legs should fit the 40-minute job cap, but I could not run the legs here (no Docker); the first PR run of this workflow is the real check.Commands run
go build -mod=vendor ./...,go vet -mod=vendor ./...,gofmt -l: cleango test -mod=vendor ./internal/plugin/... ./internal/bundle/...: passgo test -mod=vendor ./cmd/commands(full): pass (195s)go test -mod=vendor ./internal/repoqa/... ./tools/wikigen/...: passmake cmd-inventory,make wiki-check,bash scripts/ci/workflow-lint.sh: clean