Repository navigation
Conversation
|
Rebased onto current origin/main (6 commits behind, now a8250fa). Nothing needed fixing beyond the rebase: go build, go vet, gofmt and the full go test ./... pass locally on the rebased head, including the repoqa ratchets (funnel allowlists, file budget, panic baseline) and the nginx call-site list. No ratchet was changed. The gate output given was only a log-glob error from the gate host with no test failure in it, so the failure looks like staleness against main. |
|
Rebased onto current origin/main. The only failure on the rebased head was TestRollingUp/a_cancelled_context_prints_the_recovery_line. It cancelled after a fixed 300ms, which on a loaded host landed while postgres was still coming up (error read 'interrupted at service postgres'). The fake docker now drops an uphanging marker once web's up hangs, and the test cancels on that marker. cmd/commands and internal/... pass in full. The nginx call-site, docker funnel, file-budget and panic ratchets are untouched. The gate log path in the report was an unexpanded glob, so there was no log to read. |
…bounded, interrupted up says how to recover (D-0469)
…fter 300ms (D-0469)
|
Rebased onto current origin/main (clean, no conflicts) and force-pushed (0c28d73). With main's new ratchet sites in the tree, |
Per row
D-0492 (fixed).
TestNextStepno longer bounds wall-clock time (a Windows runner took 9.5s). It asserts the deadline path: theslowcase must end withctx.Err() == context.DeadlineExceededand the resultdoctor; every other case must finish withctx.Err() == nil.D-0469 (fixed, three of four items plus docs).
gateKindprints the limitHealthGatereally applies, through a newdocker.GateLimit(spec)thatHealthGatenow uses too, so the two cannot drift (healthy, max 105s, capped at 600s).up -d --no-depsin the rolling path is bounded at 15 minutes (rollingUpTimeout). A hang ends in a named error and docker is stopped.up(ctx cancelled, or docker exiting 130 before nself's handler runs) is reported as an interrupt, not a state-read failure, and the error saysService <svc> may be stopped: run 'nself restart <svc>' to bring it back.nself start <svc>, butnself startiscobra.NoArgs.nself restart [SERVICES...]is the command that takes services, so the message uses that..github/wiki/cmd-deploy.mdupdated (limit table, new paragraph). cli#629 and cli#657 are both merged.cmd/commands/deploy_rolling_up.goto keepdeploy_strategies.gounder 300 lines.D-1139 (fixed). The generated conf is
set $up_x <target>; proxy_pass $up_x;, so nginx expands any$namein a target whileroutes.jsonrecorded the literal text.validateTargetnow refuses$(error says to write%24for a literal dollar sign).TestValidateTargetgained cases; they fail on the oldbuild.goand pass now. The location in the row (route.go:99) is stale; the validator is inroutemodel/build.go.Nginx-Generation.mdupdated. The review report named in the row was not available to me, so refusing$follows the validator's existing "refuse what the model cannot represent" rule; say so if the report wanted something else.D-0237 (already fixed in the part the row describes; wrapper kept). The
ResetFlagsmutation was removed in #660 (env_target_test.gobuilds fresh command copies, and no test callsResetFlagsany more). I tried dropping the fresh-process wrapper inTestRegistryGolden: the golden then fails in a full in-process run (admingroupaccountvs committedplugins). Bisecting the test order, it first breaks onceTestCanonAccountResolutionis in the run. So the wrapper is still needed. This PR only corrects the stale comment that blamedenv_target_test.go. Dropping the wrapper needs a separate fix for that leak.D-0182 (not done, product decision).
config env explainandconfig explainare two commands over the sharedconfig.ExplainKey(different run functions, different output shapes). The row's resolution is "revisit at v1.6.0 planning", which is a command-surface decision, not a code fix.Commands run
go vet ./cmd/... ./internal/docker/ ./internal/nginx/...clean;gofmt -lclean.go test ./cmd/... ./internal/docker/... ./internal/nginx/... ./internal/deploy/... -count=1: all ok.TestRollingUp,TestGateKindPrintsTheRealLimit,TestGateLimit,TestNextStep,TestValidateTargetpass; the D-1139 cases were checked to fail against the oldbuild.go.golangci-lint runcould not be used here: it fails with typecheck errors on the standard library (go 1.27.2 toolchain), before reaching repo code.