Repository navigation
Conversation
Adds behaviour tests for EffectiveJSON, unclosed brackets in Use strings, Build input validation, unresolved V15OnlyEnvelope paths, v1.4 builtin mounts, confirm validation problems and once-per-slug plugin warnings. Package coverage 95.0% -> 99.6%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red Coverage workflow (run 40321895084):
covfloorreportedinternal/cmdregistryat 95.0% against a 96% floor.Adds
internal/cmdregistry/branches_test.gowith behaviour assertions for the uncovered branches:EffectiveJSON(was 0%): no override, unset override flag, legacy/none override, none beats legacy, nil commandbracketed/parseArgswith an unclosed bracket and nested bracketsBuildwith nil root / nil canon; unresolvedV15OnlyEnvelopepathvalidateConfirmproblems: not runnable, duplicate/empty flag, plan without flag/id_flagwarnPluginwarns once per slug; invalid plugin confirm JSON is dropped with an E437 warningApplyFlagEnvwith a nil registryThe floor is unchanged; no nolint or exclusions.
Commands run and results
go test -mod=vendor -coverprofile=c.out ./internal/cmdregistry/: 85 passed, coverage 95.0% -> 99.6%go run -mod=vendor ./tools/covfloor -profile c.out -floors .github/coverage-floors.txt:PASS internal/cmdregistry 99.6% floor 96%(package-only profile, so not run with-strict; the full-repo profile runs in CI)gofmt -landgo vet -mod=vendoron the package: cleanNot covered: the encode-error branch in
Registry.Marshal(needs an unencodable value).