Repository navigation
Conversation
The 300-line file cap cannot see a package that grows without bound or one that everything imports. Packages over 6000 non-test lines or 20 importers now need a ceiling in a shrink-only list; growth and new offenders fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-0033 — partial: package-size and fan-in ratchet added
Verified against origin/main (309e2ed):
internal/repoqa/docker_funnel_test.goalready freezes direct docker exec outsideinternal/docker(107 sites allowlisted, shrink-only). Folding those sites intointernal/dockeris not done here.internal/repoqa/package_budget_test.go):TestPackageSizeBudget: packages over 6000 non-test lines need a ceiling intestdata/package-size-allowlist.txt(8 today: cmd/commands, internal/{backup,build,config,database,deploy,doctor,plugin}).TestPackageFanInBudget: packages imported by more than 20 other packages need a ceiling intestdata/package-fanin-allowlist.txt(5 today: compat, config, docker, errs, httptimeout).-updatelowers or drops lines, never adds or raises. Documented inArchitecture-Guardrails.md.internal/pluginandinternal/configalong domain lines, and folding the ~107 ad-hoc docker exec sites intointernal/docker. Those are large refactors; the ratchet now stops further growth. The row should stay open for them.D-0122 — no change (already fixed in this repo)
docker.io/pgsty/minio(fix(compose): pull MinIO from the maintained pgsty fork #476, ADR 0028), pinned by digest ininternal/compose/images.lock.json(indexsha256:b6bfe723…); I confirmed that digest returns 200 anonymously from Docker Hub.nself doctor images(cmd/commands/doctor_images.go) probes every locked image;.github/workflows/default-images-pullable.ymlchecks every default image daily.minio/mcorquay.io/minioreference remains in cli non-test code. Remaining items are outside this repo: regenerate app repos' committed compose files and the production hosts (nself-web, ntask) still running the unpullable images.D-0162 — no change (blocked)
Still true: nothing in
build/start(internal/compose, internal/config, cmd build/start) reads.secrets/<env>.age; onlysecretscommands do. Wiring it in is the P7-TRUST / EPIC D24 work (cmd/commands/config_set_plan.gonotes it is not wired) and needs a design decision on cascade precedence and where the age identity lives at start. Not done here.Commands run
go vet ./internal/repoqa,gofmt -l internal/repoqa,go build ./...: cleango test ./internal/repoqa: okTestPackageSizeBudgetfail;-updaterestored the list byte for byte.🤖 Generated with Claude Code