Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mounted plugin commands could receive restored machine-invocation secrets on their own process arguments. Refuse these calls with E421 before starting the binary until the plugin protocol supports a secret handoff. Ordinary machine and direct calls continue to execute.
Rows verified against fresh
origin/mainat309e2ed8:3993b4eb(fix(redaction): mask basic auth and preserve loopback mappings (D-0559) #806) adds BASICAUTH to the shared secret-name rule, a generated Mailpit diff regression, and loopback mapping coverage. Redis healthchecks useREDISCLI_AUTHwith no password argument (internal/compose/cache_service.go). No changes for this row.TestPersistGeneratedSecrets_LoadKeysOnlyInInactiveEnvNotPersistedremain. Shared.env.secretsloads after the active env file; removing the guard would override another environment's real credentials. A complete fix needs an approved per-environment persistence design choosing active-env file writes or a new secrets layer and its precedence. No cascade or persistence changes made.Validation:
GOTOOLCHAIN=go1.26.10 CGO_ENABLED=0 go test -mod=vendor ./internal/config ./internal/observability ./internal/reconcile -run 'Test(IsSecretKey|RedactPreservesLoopbackPortMappings|UnifiedHidesGeneratedMailpitBasicAuth|UnifiedHidesGeneratedRedisPassword)$' -count=1: PASS.GOTOOLCHAIN=go1.26.10 CGO_ENABLED=0 go test -mod=vendor ./cmd/commands -run 'TestMountProxyRestoredSecrets|TestRestoreSecretArgvMasksRestoredValues' -count=1: PASS. Negative control with the proxy guard disabled and-run '^TestMountProxyRestoredSecrets$': both secret cases FAIL because the binary executes (exit 19). Guard restored.GOTOOLCHAIN=go1.26.10 CGO_ENABLED=0 go test -mod=vendor ./cmd/commands ./internal/invoke -count=1: PASS (303s and 21s).GOTOOLCHAIN=go1.26.10 make build BINARY=/Volumes/D5/tmp/dw4-cli-3.B5TBjH/nself: PASS.GOTOOLCHAIN=go1.26.10 CGO_ENABLED=0 go vet -mod=vendor ./cmd/commands ./internal/invoke: PASS.GOTOOLCHAIN=go1.26.10 CGO_ENABLED=0 GOFLAGS=-mod=vendor golangci-lint run ./cmd/commands/... ./internal/invoke/...: PASS, 0 issues.make fmt-checkandgit diff --check: PASS.Temporary output uses
/Volumes/D5/tmp/dw4-cli-3.B5TBjH; all Go checks use the repository-pinned toolchain and vendored dependencies. No check failures required a clean-main comparison.No HQ files changed. No release, version, production, or repository-settings changes.